Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RsaPublicKey::new_unchecked #206

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Oct 7, 2022

Constructor for RsaPublicKey which bypasses all checks around the modulus and public exponent size.

Closes #199.

Constructor for `RsaPublicKey` which bypasses all checks around the
modulus and public exponent size.
@tarcieri
Copy link
Member Author

tarcieri commented Oct 8, 2022

Hopefully this is uncontroversial enough I'm just going to merge it.

However, I'll hold off on approval before a final release.

@tarcieri tarcieri merged commit 8a1026b into master Oct 8, 2022
@tarcieri tarcieri deleted the rsa-public-key-new-unchecked branch October 8, 2022 19:02
@dignifiedquire
Copy link
Member

Thanks, looks good to me 👍

@tarcieri tarcieri mentioned this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having a MAX_PUB_EXPONENT makes this crate unusable with some applications
2 participants